-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat!: migrate stats/strided/dmaxabssorted to stats/strided/dmaxabs-sorted
#12733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,9 +32,9 @@ var pkg = require( './../package.json' ).name; | |
|
|
||
| // VARIABLES // | ||
|
|
||
| var dmaxabssorted = tryRequire( resolve( __dirname, './../lib/dmaxabssorted.native.js' ) ); | ||
| var dmaxabsSorted = tryRequire( resolve( __dirname, './../lib/dmaxabsSorted.native.js' ) ); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is why it is not enough to just do a simple find-and-replace. You need to be strategic about which regexp are used in what order. In this case, |
||
| var opts = { | ||
| 'skip': ( dmaxabssorted instanceof Error ) | ||
| 'skip': ( dmaxabsSorted instanceof Error ) | ||
| }; | ||
| var options = { | ||
| 'dtype': 'float64' | ||
|
|
@@ -66,7 +66,7 @@ function createBenchmark( len ) { | |
|
|
||
| b.tic(); | ||
| for ( i = 0; i < b.iterations; i++ ) { | ||
| v = dmaxabssorted( x.length, x, 1 ); | ||
| v = dmaxabsSorted( x.length, x, 1 ); | ||
| if ( isnan( v ) ) { | ||
| b.fail( 'should not return NaN' ); | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Neerajpathak07 This filename is not correct. It should be
dmaxabs_sorted.js. We do NOT use camelcase in filenames. We use snakecase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great understood I'll use snake casing here on!!