feat!: migrate stats/strided/dmaxabssorted to stats/strided/dmaxabs-sorted#12733
Open
Neerajpathak07 wants to merge 3 commits into
Open
feat!: migrate stats/strided/dmaxabssorted to stats/strided/dmaxabs-sorted#12733Neerajpathak07 wants to merge 3 commits into
stats/strided/dmaxabssorted to stats/strided/dmaxabs-sorted#12733Neerajpathak07 wants to merge 3 commits into
Conversation
This commit removes `@stdlib/stats/strided/dmaxabssorted` in favor of `@stdlib/stats/strided/dmaxabs-sorted`. BREAKING CHANGE: remove `stats/strided/dmaxabssorted` To migrate, users should update their require/import paths to use `@stdlib/stats/strided/dmaxabs-sorted` which provides the same API and implementation. Ref: stdlib-js#12697
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
Author
|
Let me know if my approach was correct here. Also since we were not migrating across namespace the second essential commit for removing the function from the namespace won't be present. Since the benchmarks workflow is running for all the packages of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses #12697.
Description
This pull request:
stats/strided/dmaxabssortedtostats/strided/dmaxabs-sorted.Related Issues
This pull request has the following related issues:
stats/*package naming convention from*sortedto*-sorted#12697Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers