✅ add test data for stocli2 implementation#46
Open
m4nch0t wants to merge 1 commit into
Open
Conversation
ezekiel-alexrod
added a commit
that referenced
this pull request
Jun 5, 2026
Place the storcli2 capture under each decomposed component's testdata/storcli2/ directory (controllergetter, physicaldrivegetter, logicalvolumegetter, logicalvolumemanager, blinker), mirroring the ssacli fixture layout. Add tests/testdata-tools/collect_storcli2_testdata.sh: the capture script from PR #46 with its command logic unchanged but its output remapped to this per-component layout, so the result copies straight into pkg/implementation/. A README documents the command-to-file mapping. The megaraid (storcli v1) fixtures are untouched. Three set/migrate fixtures captured as syntax-error text (storcli2 grammar change) are flagged for regeneration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.