testdata: lay out storcli2 fixtures per component package#50
Merged
Conversation
Place the storcli2 capture under each decomposed component's testdata/storcli2/ directory (controllergetter, physicaldrivegetter, logicalvolumegetter, logicalvolumemanager, blinker), mirroring the ssacli fixture layout. Add tests/testdata-tools/collect_storcli2_testdata.sh: the capture script from PR #46 with its command logic unchanged but its output remapped to this per-component layout, so the result copies straight into pkg/implementation/. A README documents the command-to-file mapping. The megaraid (storcli v1) fixtures are untouched. Three set/migrate fixtures captured as syntax-error text (storcli2 grammar change) are flagged for regeneration.
ezekiel-alexrod
force-pushed
the
improvement/storcli2-testdata-layout
branch
from
051034a to
5be1490
Compare
eg-ayoub
approved these changes
Jun 5, 2026
m4nch0t
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
storcli2 / perccli2 JSON test fixtures + capture tooling for the decomposed
storcli2 adapter. Foundation PR: no production Go code, only testdata, tooling
and docs.
Layout
Fixtures live next to each component, under
<package>/testdata/storcli2/(mirroring the ssacli adapter):
controllergetter(4),physicaldrivegetter(29),
logicalvolumegetter(25),logicalvolumemanager(9),blinker(2).Tooling
tests/testdata-tools/collect_storcli2_testdata.shreuses the original capturescript (PR #46) with its logic unchanged — only the output paths are remapped to
the per-component layout, so the result copies straight back:
cp -r ./storcli2_testdata_output/* pkg/implementation/. See its README for thecommand-to-file mapping and SAFE vs DESTRUCTIVE modes.
Notes
MegaRAID 9660-16i(24 SAS HDDs, 24 RAID0 VDs) andre-validated read-only against the live array (0 structural diffs).
with storcli v1 syntax and are flagged in the README for regeneration.