Skip to content

Fix validateSong instrument fallback logic #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julesklord wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix validateSong instrument fallback logic #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions js/songs.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tests/run-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@ runTest('Defaults to ["g"] if no valid instruments provided', () => {
// If instr: ['invalid'], filter returns [], but .length check was on ORIGINAL s.instr.
// Wait: s.instr.length is 1. filter returns []. So it returns [].
// This looks like a bug in validateSong implementation if it wants to ensure at least one valid instrument.
// But I must test the CURRENT code.
assertArrayEqual(validateSong({instr: ['invalid']}).instr, []);
// Fix: Check filtered array length instead.
assertArrayEqual(validateSong({instr: ['invalid']}).instr, ['g']);
// If instr: 'not-an-array', Array.isArray is false, returns ['g']
assertArrayEqual(validateSong({instr: 'not-an-array'}).instr, ['g']);
});
Expand Down
Loading