Fix validateSong instrument fallback logic#33
Conversation
The validateSong function was checking the original instrument array's length before filtering, which led to an empty array being returned if the input array contained only invalid instrument codes. This change modifies validateSong to check the length of the filtered instrument array, ensuring it falls back to the default ['g'] when no valid instruments are provided. Verified with updated tests in tests/run-tests.js. Co-authored-by: julesklord <801266+julesklord@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes a bug in
validateSongwhere it would return an empty instrument array if provided with an array of invalid instruments.Key changes:
validateSonginjs/songs.jsto check the filtered array length for the fallback logic.tests/run-tests.jsto assert the correct behavior.PR created automatically by Jules for task 2222308316181660949 started by @julesklord