Skip to content

feat(jdbc): Implement named parameter support in PreparedStatement #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rovshan-b wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(jdbc): Implement named parameter support in PreparedStatement #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c57341e
feat(jdbc): Implement named parameter support in PreparedStatement
rovshan-b Apr 29, 2026
ea6dec0
feat(jdbc): Introduce NamedPreparedStatement interface for named para…
rovshan-b Apr 29, 2026
bc5ece7
feat(jdbc): Simplify prepareStatement methods to always return NamedP…
rovshan-b Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions ...light-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/ArrowFlightConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,11 @@
import java.util.Properties;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.sql.PreparedStatement;
import org.apache.arrow.driver.jdbc.client.ArrowFlightSqlClientHandler;
import org.apache.arrow.driver.jdbc.client.utils.FlightClientCache;
import org.apache.arrow.driver.jdbc.utils.ArrowFlightConnectionConfigImpl;
import org.apache.arrow.driver.jdbc.utils.NamedSqlParser;
import org.apache.arrow.flight.FlightClient;
import org.apache.arrow.memory.BufferAllocator;
import org.apache.arrow.util.AutoCloseables;
Expand Down Expand Up @@ -260,4 +262,50 @@ BufferAllocator getBufferAllocator() {
public ArrowFlightMetaImpl getMeta() {
return (ArrowFlightMetaImpl) this.meta;
}

@Override
public PreparedStatement prepareStatement(String sql) throws SQLException {
NamedSqlParser.ParseResult parsed = NamedSqlParser.parse(sql);
return new NamedParamStatement(super.prepareStatement(parsed.positionalSql), parsed);
}

@Override
public PreparedStatement prepareStatement(
String sql, int resultSetType, int resultSetConcurrency) throws SQLException {
NamedSqlParser.ParseResult parsed = NamedSqlParser.parse(sql);
return new NamedParamStatement(
super.prepareStatement(parsed.positionalSql, resultSetType, resultSetConcurrency), parsed);
}

@Override
public PreparedStatement prepareStatement(
String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability)
throws SQLException {
NamedSqlParser.ParseResult parsed = NamedSqlParser.parse(sql);
return new NamedParamStatement(
super.prepareStatement(
parsed.positionalSql, resultSetType, resultSetConcurrency, resultSetHoldability),
parsed);
}

@Override
public PreparedStatement prepareStatement(String sql, int autoGeneratedKeys) throws SQLException {
NamedSqlParser.ParseResult parsed = NamedSqlParser.parse(sql);
return new NamedParamStatement(
super.prepareStatement(parsed.positionalSql, autoGeneratedKeys), parsed);
}

@Override
public PreparedStatement prepareStatement(String sql, int[] columnIndexes) throws SQLException {
NamedSqlParser.ParseResult parsed = NamedSqlParser.parse(sql);
return new NamedParamStatement(
super.prepareStatement(parsed.positionalSql, columnIndexes), parsed);
}

@Override
public PreparedStatement prepareStatement(String sql, String[] columnNames) throws SQLException {
NamedSqlParser.ParseResult parsed = NamedSqlParser.parse(sql);
return new NamedParamStatement(
super.prepareStatement(parsed.positionalSql, columnNames), parsed);
}
}
Loading