feat(jdbc): Implement named parameter support in PreparedStatement#7
Open
feat(jdbc): Implement named parameter support in PreparedStatement#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add named bind parameter support (
:namesyntax)The Arrow Flight JDBC driver previously only supported positional
?parameters. This PR addsnamed parameter support entirely on the client side — no server changes required.
Usage
conn.prepareStatement()always returns aNamedPreparedStatement(which extendsPreparedStatement), so the cast is always safe — regardless of whether the SQL uses namedor positional parameters. This matches the pattern of Oracle's
OraclePreparedStatement.All existing
setXxx(int index, …)positional calls continue to work unchanged on the same object.What's in this PR
NamedPreparedStatement.javaPreparedStatement, declares all named-paramsetXxx(String, …)methodsNamedParamStatement.javaNamedPreparedStatementdecorator; resolves each name to its 1-based positional index(es) and forwards to the delegateutils/NamedSqlParser.java:name→?, builds name→index maps, rejects mixed?/:namequeriesArrowFlightConnection.javaprepareStatement(String, …)variants to unconditionally wrap inNamedParamStatementutils/NamedSqlParserTest.javaNamedParamStatementTest.javaNotes
:name→?is client-side only — the server receives a standard positional query unchanged.col::int) are correctly left untouched.:nametokens inside string literals ('…',"…") and comments (--,/* */) are ignored.?and:namein the same query throwsSQLException.SQLException("Unknown parameter name: '<name>'").NamedParamStatementis package-private — callers always program against theNamedPreparedStatementinterface.