feat(bigframes): update ai.if_() params to match the SQL version#16857
Draft
feat(bigframes): update ai.if_() params to match the SQL version#16857
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds endpoint, optimization_mode, and max_error_ratio parameters to the ai.if_ function, updating the core operations, SQL compilation, and tests accordingly. The review feedback identifies a conflict between default parameter values that could lead to invalid BigQuery requests, potential null pointer exceptions during SQL generation, and an incorrect literal value used in a test case.
| result = bbq.ai.if_(prompt) | ||
| result = bbq.ai.if_( | ||
| prompt, | ||
| optimization_mode="maximize_quality", |
Contributor
There was a problem hiding this comment.
The value "maximize_quality" is not a valid option for optimization_mode. Based on the Literal definition in the function signature and the BigQuery ML documentation, this should be "maximize_performance".
Suggested change
| optimization_mode="maximize_quality", | |
| optimization_mode="maximize_performance", |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ai_ops.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: https://docs.cloud.google.com/bigquery/docs/reference/standard-sql/bigqueryml-syntax-ai-if
I left out the
embeddingsparam to keep things simple. It will be introduced later.