feat(fees)!: estimation correctness, wait-for-decided semantics, v0.6 parity with genlayer-js#90
Open
MuncleUscles wants to merge 1 commit into
Open
feat(fees)!: estimation correctness, wait-for-decided semantics, v0.6 parity with genlayer-js#90MuncleUscles wants to merge 1 commit into
MuncleUscles wants to merge 1 commit into
Conversation
… parity with genlayer-js Mirrors genlayer-js feat/v06-fee-estimation-rework (same designer rulings): - effective receipt gas price = max(quoteGasPrice(), eth_gasPrice); zero price on an enabled policy raises instead of producing a zero cap; effective execution budget floor = max(on-chain view, price x 306,192 gas local recompute) - simulation-derived budgets no longer clobbered by the 100M default (floor vs observed x headroom); default constant documented as provisional w/ TODO(data) - wait_until='decided'|'finalized' replaces status (legacy param mapped with one-time DeprecationWarning); new is_successful(tx) helper - enum completeness: status 14 LEADER_REVEALING (fixes a KeyError crash mid-poll), VoteType 3 TIMEOUT / 4 NONDET_DISAGREE, v0.6 ResultType remap - DEPLOY_CALL_KEY = bytes32(1) deploy sentinel; fee revert selector naming in send errors (InsufficientFees/MaxPriceExceeded/ExecutionBudgetExceeded/ BudgetTooLow/RollupBudgetBelowFloor/FeeValueMustBeNonZero) py-specific parity fixes: - asimov chain config gains FeeManager/RoundsStorage/Appeals addresses (parity with js testnetAsimov) - Studio floor-fallback formula unified with js (message-reveal leg included) - appeal_transaction/top_up_and_submit_appeal auto-resolve the minimum bond when value is omitted (previously defaulted to 0 = guaranteed on-chain revert); top_up_fees now requires value
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of genlayerlabs/genlayer-js#187 (same designer rulings, 2026-06-09 fee walkthrough), plus py-specific parity fixes.
Mirrored
max(quoteGasPrice(), eth_gasPrice); zero price on an enabled policy raises (consensus rejects zero caps withFeeValueMustBeNonZerosince CON-547); effective budget floormax(on-chain view, price × 306,192 gas).wait_until='decided'|'finalized'(legacystatusmaps with one-time DeprecationWarning); newis_successful(tx).DEPLOY_CALL_KEY = bytes32(1); fee revert selector naming in send errors.py-specific
appeal_transaction/top_up_and_submit_appealauto-resolve the minimum bond whenvalueis omitted — previously defaulted to 0, a guaranteed on-chain revert;top_up_feesnow requiresvalue.Verified: 90/90 non-network unit tests (17 testnet-marked tests require live RPC DNS, deselected as usual).