feat(gltest): fee-aware transactions and backend-agnostic success assertions#91
Open
MuncleUscles wants to merge 1 commit into
Open
feat(gltest): fee-aware transactions and backend-agnostic success assertions#91MuncleUscles wants to merge 1 commit into
MuncleUscles wants to merge 1 commit into
Conversation
…ertions - contract.transact_method / factory.deploy accept fees / fee_value / wait_until and thread them verbatim to genlayer-py (SDK resolves defaults; gltest does not re-implement estimation); deprecated status= kwarg dropped in favor of wait_until 'decided'/'finalized' - direct/sim mode ignores fee kwargs gracefully (gasless by design) - tx_execution_succeeded now requires consensus acceptance and recognizes both receipt shapes: Studio (leader_receipt.execution_result == SUCCESS) and testnet (tx_execution_result_name == FINISHED_WITH_RETURN), preferring genlayer_py.transactions.is_successful — an UNDETERMINED tx with a leader FINISHED_WITH_RETURN result is now correctly False - genlayer-py dependency relaxed to <0.20.0 (fee-aware 0.19 line)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the 'gltest cannot test fee-enabled backends at all' gap from the fee audit.
transact_method/deployacceptfees/fee_value/wait_untiland thread them verbatim to genlayer-py (SDK resolves defaults — gltest does not re-implement estimation). Deprecatedstatus=kwarg replaced bywait_until 'decided'/'finalized'.tx_execution_succeedednow requires consensus acceptance and recognizes both receipt shapes (Studioleader_receipt.execution_result == SUCCESS; testnettx_execution_result_name == FINISHED_WITH_RETURN), preferringgenlayer_py.transactions.is_successful. An UNDETERMINED tx with a leader FINISHED_WITH_RETURN result is now correctly False — the leader's result exists even without a validator majority.<0.20.0(fee-aware 0.19 line).209 tests green (the 22 example-suite failures pre-exist on base — missing contracts/ scaffold, environmental). Depends on genlayerlabs/genlayer-py#90 for wait_until/is_successful.