Skip to content

Drop dead SAC parser entries from SACConstants and the factory #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 2 commits into from
May 7, 2026
+3 −26
Merged

Drop dead SAC parser entries from SACConstants and the factory #3977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9efb93
Drop dead SAC parser entries from SACConstants and the factory
vogella May 7, 2026
d44a156
Version bump(s) for 4.40 stream
eclipse-platform-bot May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.ui.css.core/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Bundle-SymbolicName: org.eclipse.e4.ui.css.core;singleton:=true
Bundle-Name: %pluginName
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Bundle-Version: 0.14.600.qualifier
Bundle-Version: 0.14.700.qualifier
Export-Package: org.eclipse.e4.ui.css.core;x-internal:=true,
org.eclipse.e4.ui.css.core.css2;x-friends:="org.eclipse.e4.ui.css.swt.theme,org.eclipse.e4.ui.css.swt,org.eclipse.e4.ui.css.jface",
org.eclipse.e4.ui.css.core.dom;x-friends:="org.eclipse.e4.ui.css.swt,org.eclipse.ui.views.properties.tabbed,org.eclipse.ui.forms",
Expand Down
15 changes: 0 additions & 15 deletions bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/SACConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,6 @@
*/
public class SACConstants {

/**
* org.w3c.flute.parser.Parser SAC Parser.
*/
public static final String SACPARSER_FLUTE = "org.w3c.flute.parser.Parser";

/**
* org.w3c.flute.parser.Parser SAC Parser.
*/
public static final String SACPARSER_FLUTE_CSS3 = "org.w3c.flute.parser.CSS3Parser";

/**
* com.steadystate.css.parser.SACParser SAC Parser
*/
public static final String SACPARSER_STEADYSTATE = "com.steadystate.css.parser.SACParser";

/**
* org.apache.batik.css.parser.Parser SAC Parser.
*/
Expand Down
12 changes: 2 additions & 10 deletions ....eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/sac/SACParserFactoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,18 @@
import org.w3c.css.sac.Parser;

/**
* SAC Parser factory implementation. By default, this SAC FActory support
* Flute, SteadyState and Batik SAC Parser.
* SAC Parser factory implementation. The Batik SAC parser is the only
* parser shipped with Eclipse and is registered as the default.
*/
public class SACParserFactoryImpl extends SACParserFactory {

private static Map<String, String> parsers = new HashMap<>();

static {
// Register Flute SAC Parser
registerSACParser(SACConstants.SACPARSER_FLUTE);
// Register Flute SAC CSS3Parser
registerSACParser(SACConstants.SACPARSER_FLUTE_CSS3);
// Register SteadyState SAC Parser
registerSACParser(SACConstants.SACPARSER_STEADYSTATE);
// Register Batik SAC Parser
registerSACParser(SACConstants.SACPARSER_BATIK);
}

public SACParserFactoryImpl() {
// Flute parser is the default SAC Parser to use.
super.setPreferredParserName(SACConstants.SACPARSER_BATIK);
}

Expand Down
Loading