Skip to content

Drop dead SAC parser entries from SACConstants and the factory#3977

Merged
akurtakov merged 2 commits intoeclipse-platform:masterfrom
vogella:remove-dead-sac-parser-entries
May 7, 2026
Merged

Drop dead SAC parser entries from SACConstants and the factory#3977
akurtakov merged 2 commits intoeclipse-platform:masterfrom
vogella:remove-dead-sac-parser-entries

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented May 7, 2026

Eclipse only ships the Batik CSS parser. The Flute, Flute CSS3, and SteadyState parser entries in SACConstants and the matching registerSACParser calls in SACParserFactoryImpl reference parser classes that are not on the runtime classpath; calling makeParser with any of those names would fail with ClassNotFoundException. Remove the three dead constants and registrations, and fix a stale comment that claimed Flute was the default parser when in fact the factory has always preferred Batik.

vogella and others added 2 commits May 7, 2026 05:58
Eclipse only ships the Batik CSS parser. The Flute, Flute CSS3, and
SteadyState parser entries in SACConstants and the matching
registerSACParser calls in SACParserFactoryImpl reference parser
classes that are not on the runtime classpath; calling makeParser
with any of those names would fail with ClassNotFoundException.
Remove the three dead constants and registrations, and fix a stale
comment that claimed Flute was the default parser when in fact the
factory has always preferred Batik.
@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.css.core/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From e15805de6e176977e138a209aba961f7f2f259f5 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Thu, 7 May 2026 04:05:35 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/bundles/org.eclipse.e4.ui.css.core/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.css.core/META-INF/MANIFEST.MF
index 459c82913a..100f3ec52a 100644
--- a/bundles/org.eclipse.e4.ui.css.core/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.css.core/META-INF/MANIFEST.MF
@@ -4,7 +4,7 @@ Bundle-SymbolicName: org.eclipse.e4.ui.css.core;singleton:=true
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-Bundle-Version: 0.14.600.qualifier
+Bundle-Version: 0.14.700.qualifier
 Export-Package: org.eclipse.e4.ui.css.core;x-internal:=true,
  org.eclipse.e4.ui.css.core.css2;x-friends:="org.eclipse.e4.ui.css.swt.theme,org.eclipse.e4.ui.css.swt,org.eclipse.e4.ui.css.jface",
  org.eclipse.e4.ui.css.core.dom;x-friends:="org.eclipse.e4.ui.css.swt,org.eclipse.ui.views.properties.tabbed,org.eclipse.ui.forms",
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Test Results

   852 files  ±0     852 suites  ±0   52m 55s ⏱️ - 4m 32s
 7 954 tests ±0   7 711 ✅ ±0  243 💤 ±0  0 ❌ ±0 
20 364 runs  ±0  19 709 ✅ ±0  655 💤 ±0  0 ❌ ±0 

Results for commit d44a156. ± Comparison against base commit 7e65263.

@akurtakov akurtakov merged commit 4aeae2e into eclipse-platform:master May 7, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants