feat(sim): dimsim as connection#1735
Conversation
Greptile SummaryThis PR introduces DimSim as a new lightweight simulator backend for the Unitree Go2 robot, alongside the MuJoCo simulator, by adding a
Confidence Score: 2/5Not safe to merge: the DimSim backend is non-functional in several core areas that the e2e tests depend on. The DimSimConnection adapter ships with move() returning True without publishing any cmd_vel command, and all three data streams (odom_stream, lidar_stream, video_stream) are silent Subjects that never receive data. The e2e walk-forward test will always time out because wait_until_odom_position listens to /odom LCM messages that _handle_odom never forwards to the Subject. The SceneClient recv loop can crash permanently on a late exec result after a timeout. Together these issues mean the primary tested feature cannot work end-to-end as written. dimos/robot/unitree/dimsim_connection.py (move() stub, silent streams), dimos/simulation/dimsim/scene_client.py (_recv_loop crash, WS send race), dimos/simulation/dimsim/dimsim_process.py (personal fork URL, partial clone recovery, stop/log-reader race) Important Files Changed
Reviews (19): Last reviewed commit: "remove 3.15" | Re-trigger Greptile |
9d01ca0 to
d26e60d
Compare
6e02118 to
1aec40d
Compare
7851b03 to
139e176
Compare
c1fa423 to
054c9ec
Compare
054c9ec to
55afcff
Compare
55afcff to
e3baf66
Compare
e3baf66 to
3f5a71e
Compare
2f00cad to
96d8638
Compare
96d8638 to
36391fb
Compare
36391fb to
377385b
Compare
377385b to
2dde795
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
2dde795 to
e3adc99
Compare
leshy
left a comment
There was a problem hiding this comment.
I have no notes on this apart from LCM, can fix in the followup, amazing!
e3adc99 to
b722d89
Compare
Co-authored-by: Viswajit Nair <viswajitnair@gmail.com>
b722d89 to
47ef883
Compare
47ef883 to
0815c18
Compare
Problem
We need a light-er weight simulator.
Closes DIM-xxx
Solution
Breaking Changes
The
--simulationflag now takes a parameter: eithermujocoordimsim.How to Test
Run the apt scene:
Run the empty scene:
Run the dimsim tests:
Contributor License Agreement