Skip to content

Pull in Beta Features#473

Merged
makermelissa merged 18 commits intomainfrom
beta
Apr 23, 2026
Merged

Pull in Beta Features#473
makermelissa merged 18 commits intomainfrom
beta

Conversation

@makermelissa
Copy link
Copy Markdown
Collaborator

This pulls in the latest Beta features into the main editor before the codebases get too far apart.

makermelissa and others added 16 commits December 23, 2025 09:53
Package Updates + Detect safe mode and notify when restarting
Bumps [@xterm/xterm](https://github.com/xtermjs/xterm.js) from 5.5.0 to 6.0.0.
- [Release notes](https://github.com/xtermjs/xterm.js/releases)
- [Commits](xtermjs/xterm.js@5.5.0...6.0.0)

---
updated-dependencies:
- dependency-name: "@xterm/xterm"
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Change text input to custom dialog
…erm/xterm-6.0.0

Bump @xterm/xterm from 5.5.0 to 6.0.0
Add settings and theme options
Code and Serial Panels printable
Copy link
Copy Markdown
Contributor

@makermelissa-piclaw makermelissa-piclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice batch of improvements — settings/themes, the custom input dialog replacing prompt(), safe-mode detection, print support, and panel focus management all look solid. CI is green. A couple of things caught my eye:


Bug — save retry calls the function immediately instead of deferring it

In js/script.js, the save-retry change:

currentTimeout = setTimeout(await saveFileContents(path), 2000);

This calls saveFileContents(path) right away (and awaits it), then passes its resolved return value to setTimeout — so the 2-second delay never actually happens and retries fire immediately in a tight loop. The original code had the same conceptual issue (no path arg was forwarded), but the fix accidentally made it worse by adding await.

Should probably be:

currentTimeout = setTimeout(() => saveFileContents(path), 2000);

Minor — _themes.scss typo

--puctuation-color is defined in both dark and light roots — looks like it should be --punctuation-color. It's used in the .tok-punctuation rule, so if someone tries to reference it by the correct spelling later it'll silently fall back.


Nit — missing newlines at EOF

A few files lost their trailing newline (layout.js, _base.scss, dialogs.js). Not a big deal, but some linters/diff tools get noisy about it.


Everything else looks great — the isLocal() logic fix, the comment fix for isChromeOs(), the theme CSS variable extraction, and the InputModal class are all clean. 👍

- Fix setTimeout in saveFileContents retry to use arrow function instead
  of immediately invoking the function (caused tight retry loop)
- Fix --puctuation-color typo to --punctuation-color in _themes.scss
- Add missing trailing newlines to layout.js, _base.scss, dialogs.js
Fix save retry loop, punctuation CSS typo, and missing EOF newlines
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 23, 2026

Deploying web-editor with  Cloudflare Pages  Cloudflare Pages

Latest commit: b58df41
Status: ✅  Deploy successful!
Preview URL: https://1081bf5b.web-editor-2j8.pages.dev

View logs

@makermelissa makermelissa merged commit dc5d5f5 into main Apr 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants