Fix save retry loop, punctuation CSS typo, and missing EOF newlines#474
Merged
makermelissa merged 1 commit intocircuitpython:betafrom Apr 23, 2026
Merged
Conversation
- Fix setTimeout in saveFileContents retry to use arrow function instead of immediately invoking the function (caused tight retry loop) - Fix --puctuation-color typo to --punctuation-color in _themes.scss - Add missing trailing newlines to layout.js, _base.scss, dialogs.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three issues spotted during review of #473:
1. Bug — Save retry fires immediately instead of after 2s delay
setTimeout(await saveFileContents(path), 2000)calls the function immediately (andawaits it), then passes the resolved return value tosetTimeout. This creates a tight retry loop instead of a 2-second backoff.Fix: Wrap in an arrow function so
setTimeoutdefers the call:2. Minor — CSS variable typo in
_themes.scss--puctuation-color→--punctuation-color(missing 'n') in both dark and light theme roots and the.tok-punctuationrule.3. Nit — Missing trailing newlines
Added missing final newlines to
js/layout.js,sass/base/_base.scss, andjs/common/dialogs.js.