Skip to content

update iceberg add files parameters #38879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derrickaw wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

update iceberg add files parameters #38879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdks/python/apache_beam/yaml/standard_io.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,9 +418,11 @@
catalog_properties: 'catalog_properties'
config_properties: 'config_properties'
triggering_frequency_seconds: 'triggering_frequency_seconds'
manifest_file_size: 'manifest_file_size'

@gemini-code-assist gemini-code-assist Bot Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When adding new parameters to the mappings of an underlying provider, they must also be defined in the properties schema of the transform (typically located above the underlying_provider section in this file). If they are omitted from the schema, YAML validation will fail when these parameters are used in pipelines (such as in the test file). Add manifest_file_size (as an integer) and sort_fields (as an array of strings) to the transform's properties schema if they are not already present.

location_prefix: 'location_prefix'
partition_fields: 'partition_fields'
table_properties: 'table_properties'
sort_fields: 'sort_fields'
error_handling: 'error_handling'
underlying_provider:
type: beamJar
Expand Down
3 changes: 3 additions & 0 deletions sdks/python/apache_beam/yaml/tests/iceberg_add_files.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ pipelines:
catalog_properties:
type: "hadoop"
warehouse: "{TEMP_DIR}/dir"
manifest_file_size: 50
sort_fields:
- "rank desc"

# Pipeline 3: Read from Iceberg and verify the contents
- pipeline:
Expand Down
Loading