update iceberg add files parameters#38879
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the configuration capabilities for Iceberg IO within the Apache Beam YAML SDK. By exposing 'manifest_file_size' and 'sort_fields' as configurable parameters, users gain finer control over the Iceberg table writing process. The changes include updates to the standard IO definitions and corresponding integration tests to ensure these new parameters are correctly handled. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for manifest_file_size and sort_fields to the Iceberg YAML configuration and updates the test pipeline to use them. The review feedback points out that these new parameters must also be defined in the properties schema of the transform to prevent YAML validation failures.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| catalog_properties: 'catalog_properties' | ||
| config_properties: 'config_properties' | ||
| triggering_frequency_seconds: 'triggering_frequency_seconds' | ||
| manifest_file_size: 'manifest_file_size' |
There was a problem hiding this comment.
When adding new parameters to the mappings of an underlying provider, they must also be defined in the properties schema of the transform (typically located above the underlying_provider section in this file). If they are omitted from the schema, YAML validation will fail when these parameters are used in pipelines (such as in the test file). Add manifest_file_size (as an integer) and sort_fields (as an array of strings) to the transform's properties schema if they are not already present.
|
Assigning reviewers: R: @tvalentyn for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.