Skip to content

Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 5 |Prep exercises#510

Open
enjoy15 wants to merge 9 commits into
CodeYourFuture:mainfrom
enjoy15:sprint5-prep-excercises
Open

Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 5 |Prep exercises#510
enjoy15 wants to merge 9 commits into
CodeYourFuture:mainfrom
enjoy15:sprint5-prep-excercises

Conversation

@enjoy15
Copy link
Copy Markdown

@enjoy15 enjoy15 commented Apr 22, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all exercises

@enjoy15 enjoy15 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 5 Assigned during Week 5 of this module labels Apr 22, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 13, 2026
Copy link
Copy Markdown
Contributor

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "double" prep exercise is missing
The methods task is missing an explanation, otherwise all good.

@@ -0,0 +1,28 @@
from datetime import date

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanations of methods vs functions is missing

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to separate out useful helper functions for parsing inputs

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 5 Assigned during Week 5 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants