Add configurable JVM memory settings for jdtls#238
Merged
tartarughina merged 3 commits intozed-extensions:mainfrom May 5, 2026
Merged
Add configurable JVM memory settings for jdtls#238tartarughina merged 3 commits intozed-extensions:mainfrom
tartarughina merged 3 commits intozed-extensions:mainfrom
Conversation
Add `get_max_memory` and `get_min_memory` config functions to read heap size settings. Implement `parse_memory_value` to convert JVM memory strings (e.g. "2G", "512m") to bytes. Update launch args to use configured values with validation to ensure min doesn't exceed max, defaulting to "1G" for initial heap.
playdohface
approved these changes
May 5, 2026
Collaborator
playdohface
left a comment
playdohface
left a comment
There was a problem hiding this comment.
I guess this helps a little bit, but I reckon it'll just allow changing the behavior from eating all the RAM to crashing JDTLS for the affected users. We should try to recreate the issue and properly triage it at some point, JDTLS is probably partly at fault here.
1 task
Collaborator
Author
|
I agree, not a solution to the issues you mentioned but rather a customization that for systems with hardware limitations could represent a nice to have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
get_max_memoryandget_min_memoryconfig functions to read heap size settings. Implementparse_memory_valueto convert JVM memory strings (e.g. "2G", "512m") to bytes. Update launch args to use configured values with validation to ensure min doesn't exceed max, defaulting to "1G" for initial heap.Address #234