fix: apply path normalization to fsspec store#3924
Merged
d-v-b merged 4 commits intozarr-developers:mainfrom Apr 24, 2026
Merged
fix: apply path normalization to fsspec store#3924d-v-b merged 4 commits intozarr-developers:mainfrom
d-v-b merged 4 commits intozarr-developers:mainfrom
Conversation
github-actions
Bot
added
the
needs release notes
github-actions
Bot
removed
the
needs release notes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3924 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 85 85
Lines 11365 11365
=======================================
Hits 10582 10582
Misses 783 783
🚀 New features to boost your workflow:
|
Member
|
Confirmed this branch fixes the downstream failure I was seeing in VirtualiZarr (zarr-developers/VirtualiZarr#957 (comment)) |
Member
|
@davis Bennett the CI seems to be stuck here somehow? Any chance we could just yolo merge this in now so that I can keep on testing VZ against zarr-python 3.2.0's new features? |
Contributor
Author
I can't self-merge PRs, so we need another dev to approve it. |
maxrjones
approved these changes
Apr 23, 2026
Member
|
oh look at that 😉 |
8 tasks
d-v-b
added a commit
that referenced
this pull request
Apr 29, 2026
* fix(storage): preserve leading slashes in FsspecStore.path #3924 ran the constructor's `path` argument through `normalize_path`, which is intended for zarr logical keys and strips leading slashes. Applied to a filesystem-side root, this turned absolute paths like /home/foo/data.zarr into the relative home/foo/data.zarr, breaking LocalFileSystem-backed FsspecStore for any caller that passed an absolute path. Downstream impact: titiler-xarray's test-upstream job fails on every dataset_3d.zarr fixture access. The original #3922 issue (path="/" producing "//key" via _join_paths) is still resolved: rstrip("/") collapses "/" to "", so the join filter drops it. Trailing slashes are also still stripped. Updates the existing test_fsspec_store_path_normalization parametrization with the new (correct) expectations and adds two absolute-path cases. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs: changelog name * docs: remove redundant changelog entries * fix: restore old path normalization logic, and add regression tests --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply path normalization to the fsspecstore.path attribute.
closes #3922