Notify users that they haven't login in a while and deactivate accounts#596
Open
santostiago wants to merge 2 commits into
Open
Notify users that they haven't login in a while and deactivate accounts#596santostiago wants to merge 2 commits into
santostiago wants to merge 2 commits into
Conversation
santostiago
force-pushed
the
job/automatically-deactivate-old-accounts
branch
from
4ddd988 to
9dbff88
Compare
tsubik
requested changes
May 8, 2026
| subject(:run_task) { Rake::Task["scheduler:deactivate_inactive_users"].invoke } | ||
|
|
||
| around do |example| | ||
| travel_to(Time.zone.parse("2026-04-30 10:00:00")) { example.run } |
Collaborator
There was a problem hiding this comment.
Is it necessary to set fixed time here for every example?
| account_deactivated_for_inactivity: | ||
| subject: "Your Open Timber Portal account has been deactivated" | ||
| message: "Because your account has not been used for 2 years, it is now deactivated." | ||
| contact: "If you need help or think this is an error, please contact the OTP team." |
Collaborator
There was a problem hiding this comment.
Should we put CONTACT_EMAIL here as well? I think question to Sophie.
| deactivated_users = 0 | ||
|
|
||
| time = Benchmark.ms do | ||
| warning_users = User.where(is_active: true) |
Collaborator
There was a problem hiding this comment.
We should filter out special user webuser@example.com, that user cannot be deactivated.
| warned_users += 1 | ||
| end | ||
|
|
||
| users_to_deactivate = User.where(is_active: true) |
Collaborator
There was a problem hiding this comment.
I wonder should we at least warn user once? Or just go straight to deactivate. The problem is only for the first run. I see a lot of users will be deactivated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
Issue Number: https://gfw.atlassian.net/browse/OPEN-376
What is the new behavior?
We run a job every day that warns users that haven't logged in in a while that their accounts will be disabled.
Disable users that have not logged in in 2 years.
Does this introduce a breaking change?
Other information