Skip to content

fix: list Slack as an auth provider for the authorization URL#633

Merged
gjtorikian merged 2 commits intoworkos:mainfrom
tgwizard:add-slack-auth-provider
Apr 24, 2026
Merged

fix: list Slack as an auth provider for the authorization URL#633
gjtorikian merged 2 commits intoworkos:mainfrom
tgwizard:add-slack-auth-provider

Conversation

@tgwizard
Copy link
Copy Markdown
Contributor

@tgwizard tgwizard commented Apr 24, 2026

Description

Slack wasn't in here, but it works. I want to use it in workos_client.user_management.get_authorization_url. (This list seems somewhat inconsistent with other lists).

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[x] No

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@tgwizard tgwizard requested review from a team as code owners April 24, 2026 07:06
@tgwizard tgwizard requested a review from PavanKulkarni April 24, 2026 07:06
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 24, 2026

Greptile Summary

This PR expands the SSOProvider and UserManagementAuthenticationProvider enums (and their corresponding Literal TypeAliases) to include Slack and eight other OAuth providers that were previously missing. Both the Enum members and the Literal TypeAliases are kept in sync across both files, and the previously-flagged P1 (missing "SlackOAuth" in UserManagementAuthenticationProviderLiteral) is fully resolved in this revision.

Confidence Score: 5/5

Safe to merge — no P0/P1 issues; only a P2 note about manual edits to auto-generated files.

All Enum/Literal pairs are in sync, the previous P1 is resolved, and no logic or security concerns are introduced. The sole open concern (auto-generated file header) is P2.

No files require special attention beyond the auto-generated file caveat already noted.

Important Files Changed

Filename Overview
src/workos/sso/models/sso_provider.py Added 9 new OAuth providers (Bitbucket, Discord, GitLab, Intuit, LinkedIn, Salesforce, Slack, Vercel, VercelMarketplace, Xero) to both the Enum and Literal TypeAlias, keeping them in sync. File header says auto-generated.
src/workos/user_management/models/user_management_authentication_provider.py Added same 9 new OAuth providers to both the Enum and Literal TypeAlias (including SlackOAuth), fully resolving the previously-flagged P1. Also consolidated duplicate typing imports. File header says auto-generated.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[get_authorization_url] --> B{provider type?}
    B --> C[UserManagementAuthenticationProvider Enum]
    B --> D[UserManagementAuthenticationProviderLiteral TypeAlias]
    C --> E[authkit / AppleOAuth / BitbucketOAuth / DiscordOAuth / GitHubOAuth / GitLabOAuth / GoogleOAuth / IntuitOAuth / LinkedInOAuth / MicrosoftOAuth / SalesforceOAuth / SlackOAuth NEW / VercelMarketplaceOAuth / VercelOAuth / XeroOAuth]
    D --> E
    F[SSOProvider Enum] --> G[AppleOAuth / BitbucketOAuth / DiscordOAuth / GitHubOAuth / GitLabOAuth / GoogleOAuth / IntuitOAuth / LinkedInOAuth / MicrosoftOAuth / SalesforceOAuth / SlackOAuth NEW / VercelMarketplaceOAuth / VercelOAuth / XeroOAuth]
    H[SSOProviderLiteral TypeAlias] --> G
Loading

Reviews (3): Last reviewed commit: "update with full list" | Re-trigger Greptile

@tgwizard tgwizard force-pushed the add-slack-auth-provider branch from 04eaf1b to 965d07e Compare April 24, 2026 08:07
@gjtorikian gjtorikian changed the title List Slack as an auth provider for the authorization URL fix: list Slack as an auth provider for the authorization URL Apr 24, 2026
@gjtorikian gjtorikian merged commit 87fc5ab into workos:main Apr 24, 2026
10 checks passed
@gjtorikian
Copy link
Copy Markdown
Contributor

Hey, thanks for this!

These files are now automatically generated by our OpenAPI spec and completely machine generated (This file is auto-generated by oagen.) -- so I updated that YAML and produced the full complete list here. This'll be out in the next patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants