Post-close /simplify pass on M01 sources#2
Merged
Conversation
Seven small fixes after a code-review sweep, documented in the M01
brief's Acted deviations as a post-close Cas 3 verbal addendum.
- minisign(trailing-bytes): fix stale offset reference flagged in
M01 closing notes (sigInfoEnd -> globalSigEnd) so the trailing-
bytes guard becomes effective again
- cache: drop pointless getZigCacheRestoreKeys wrapper + test
- gc: replace 9-case switch with Record<string, number> multiplier
lookup
- gc(dirSize): parallel-stat via Promise.all instead of serial loop
- resolve(mach): tighten alias check (endsWith('-mach') instead of
includes('mach'))
- post: drop @actions/github dependency in favor of GITHUB_RUN_ID
env var
- main: remove redundant usedTarballPath local
89/89 tests green; typecheck/lint/prettier clean. dist/ rebuilt to
preserve the byte-for-byte parity enforced by lint.yml.
Refs: briefs/M01-initial-implementation.md (Acted deviations)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-close code-review sweep on the M01 sources, applied as a Cas 3 verbal addendum to the M01 brief (documented in briefs/M01-initial-implementation.md under Acted deviations).
Seven small fixes, no behavior change beyond the minisign trailing-bytes guard becoming effective:
sigInfoEnd→globalSigEnd). Departs from the verbatim-port "minimal changes" mandate, but fixes a latent bug rather than a behavior — explicitly identified in the brief as a future hardening, applied opportunistically here.getZigCacheRestoreKeyswrapper + its testswitchwithRecord<string, number>multiplier lookupPromise.allinstead of serialforloopincludes('mach')toendsWith('-mach')@actions/githubdep (only used forrunId, replaced byGITHUB_RUN_IDenv var)usedTarballPathlocaldist/rebuilt to preserve the byte-for-byte parity enforced bylint.yml.Test plan
npm test— 89/89 tests passing locallynpm run typecheck— cleannpm run lint— cleannpm run format:check— cleannpm run build—dist/index.js+dist/post.jsrebuiltlint.ymldist-reproducibility job confirmsdist/matches a fresh rebuild🤖 Generated with Claude Code