Add tests for HorizonPrometheusExporter and our Custom Exporters#1105
Merged
Add tests for HorizonPrometheusExporter and our Custom Exporters#1105
Conversation
Add some simple tests. These instantiate the existing exporters and check that their collection method works. Another test instantiates the exporter repository with our application config to check it is valid Bug: T423429
tarrow
force-pushed
the
test-horizon-prometheus-exporter
branch
from
6eca64d to
1eb71d7
Compare
outdooracorn
approved these changes
Apr 23, 2026
Member
outdooracorn
left a comment
outdooracorn
left a comment
There was a problem hiding this comment.
Thanks for this; it looks good!
I've left some minor comments - take them or leave them :)
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some simple tests. These instantiate the existing exporters and check that their collection method works. Another test instantiates the exporter repository with our application config to check it is valid
Bug: T423429