Fix CUTLASS local work driver setup#213
Open
awvwgk wants to merge 1 commit into
Open
Conversation
Coauthored-by: "Thomas D. Kuehne" <tkuehne@cp2k.org>
wavefunction91
requested changes
Jun 9, 2026
|
|
||
| FetchContent_MakeAvailable( exchcxx ) | ||
|
|
||
| if( CMAKE_POSITION_INDEPENDENT_CODE AND TARGET exchcxx ) |
Owner
There was a problem hiding this comment.
I'm fine with this in principle, but can you point to the point where this caused an error for the current bug fix? This applies to the other instance as well.
| #endif | ||
|
|
||
| namespace GauXC { | ||
| namespace { |
Owner
There was a problem hiding this comment.
Please done use anonymous namespaces. "detail" would be appropriate here.
| namespace GauXC { | ||
| namespace { | ||
|
|
||
| void trim_and_uppercase(std::string& name) { |
Owner
There was a problem hiding this comment.
Since this is only used once, I don't see the value in adding the helper function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #206