fix: stop run-install after install failure#60
Closed
lyzno1 wants to merge 1 commit intovoidzero-dev:mainfrom
Closed
fix: stop run-install after install failure#60lyzno1 wants to merge 1 commit intovoidzero-dev:mainfrom
lyzno1 wants to merge 1 commit intovoidzero-dev:mainfrom
Conversation
7045a79 to
eaf2b03
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the run-install step to fail fast: when any vp install invocation fails, the action now throws to stop processing subsequent run-install entries, and includes a regression test to enforce the behavior.
Changes:
- Make
runViteInstallthrow onvp installfailure (non-zero exit code or exec error) to stop the loop immediately. - Add unit test coverage ensuring subsequent
run-installentries are not executed after the first failure. - Rebuild
dist/index.mjsto reflect the updated runtime behavior.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/run-install.ts |
Switch from setFailed to throwing errors so run-install halts on first failure. |
src/run-install.test.ts |
Adds regression test asserting the loop stops after the first failed install. |
dist/index.mjs |
Updated compiled output reflecting the new failure/throw behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes #61