Skip to content

fix: stop run-install after install failure#60

Closed
lyzno1 wants to merge 1 commit intovoidzero-dev:mainfrom
lyzno1:yyh/fix-run-install-failure
Closed

fix: stop run-install after install failure#60
lyzno1 wants to merge 1 commit intovoidzero-dev:mainfrom
lyzno1:yyh/fix-run-install-failure

Conversation

@lyzno1
Copy link
Copy Markdown

@lyzno1 lyzno1 commented Apr 25, 2026

Summary

  • throw when a vp install command fails so later run-install entries do not continue
  • add regression coverage for multi-entry run-install failure handling
  • rebuild dist/index.mjs

Verification

  • vp run test
  • vp run typecheck
  • vp run check:fix
  • vp run build

Fixes #61

Copilot AI review requested due to automatic review settings April 25, 2026 15:11
@lyzno1 lyzno1 force-pushed the yyh/fix-run-install-failure branch from 7045a79 to eaf2b03 Compare April 25, 2026 15:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the run-install step to fail fast: when any vp install invocation fails, the action now throws to stop processing subsequent run-install entries, and includes a regression test to enforce the behavior.

Changes:

  • Make runViteInstall throw on vp install failure (non-zero exit code or exec error) to stop the loop immediately.
  • Add unit test coverage ensuring subsequent run-install entries are not executed after the first failure.
  • Rebuild dist/index.mjs to reflect the updated runtime behavior.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/run-install.ts Switch from setFailed to throwing errors so run-install halts on first failure.
src/run-install.test.ts Adds regression test asserting the loop stops after the first failed install.
dist/index.mjs Updated compiled output reflecting the new failure/throw behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lyzno1 lyzno1 marked this pull request as draft April 25, 2026 15:18
@lyzno1 lyzno1 closed this Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop run-install after an install failure

2 participants