feat(pushqueue): add land and ping controllers with tests#236
Open
kevinlnew wants to merge 1 commit into
Open
Conversation
This was referenced Jun 10, 2026
|
|
kevinlnew
force-pushed
the
pushqueue/chunk1-controllers
branch
from
a5d80d0 to
a501ba3
Compare
kevinlnew
force-pushed
the
pushqueue/chunk1-entities
branch
from
b7c9025 to
466e410
Compare
kevinlnew
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
kevinlnew
force-pushed
the
pushqueue/chunk1-entities
branch
from
466e410 to
49b58f4
Compare
kevinlnew
force-pushed
the
pushqueue/chunk1-controllers
branch
from
a501ba3 to
f1c4d8c
Compare
kevinlnew
force-pushed
the
pushqueue/chunk1-entities
branch
from
49b58f4 to
f39a209
Compare
kevinlnew
force-pushed
the
pushqueue/chunk1-controllers
branch
2 times, most recently
from
82f4d87 to
c4d2722
Compare
kevinlnew
force-pushed
the
pushqueue/chunk1-entities
branch
from
8a8edad to
4d2c36b
Compare
kevinlnew
force-pushed
the
pushqueue/chunk1-controllers
branch
from
c4d2722 to
24fac27
Compare
Land controller orchestrates enqueue → wait → push → finalize flow with error classification (conflict=user, stale head=retryable). Ping controller uses SugaredLogger. Regenerates mocks with go.uber.org/mock and fixes proto BUILD disambiguation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kevinlnew
force-pushed
the
pushqueue/chunk1-controllers
branch
from
24fac27 to
576d6ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Land controller orchestrates enqueue → wait → push → finalize flow
with error classification (conflict=user, stale head=retryable).
Ping controller uses SugaredLogger. Regenerates mocks with
go.uber.org/mock and fixes proto BUILD disambiguation.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Test Plan
Issues