Skip to content

Reduce dependency on values.yaml file for requests proxy#122

Merged
saqlainsyed007 merged 1 commit into
developfrom
requests-proxy
May 14, 2026
Merged

Reduce dependency on values.yaml file for requests proxy#122
saqlainsyed007 merged 1 commit into
developfrom
requests-proxy

Conversation

@saqlainsyed007
Copy link
Copy Markdown

@saqlainsyed007 saqlainsyed007 commented May 14, 2026

Summary

Related

Type of change

  • Feature
  • Bug fix
  • Tech-debt / refactor
  • Docs
  • Security / hardening
  • Breaking change

Test plan

Screenshots / recordings

Deployment notes

Checklist

  • Tests added / updated and passing locally
  • Docs updated if behavior or config changed
  • No secrets / credentials in the diff
  • For security-sensitive paths: appropriate reviewer requested

Note

Medium Risk
Changes requests-proxy deployment defaults by hardcoding CPU/memory and forcing imagePullPolicy: Always, which can affect scheduling and rollout/pull behavior across clusters.

Overview
requests-proxy’s Helm template now hardcodes its CPU/memory requests+limits and sets imagePullPolicy: Always, rather than reading resource settings (or pull policy) from values.yaml.

The image digest lookup is also made more defensive by using dig "requestsProxy" "digest" against .Values.images, and the resources.requestsProxy block is removed from client/values.yaml.

Reviewed by Cursor Bugbot for commit 60387e1. Bugbot is set up for automated code reviews on this repo. Configure here.

@saqlainsyed007 saqlainsyed007 requested a review from saadqbal as a code owner May 14, 2026 12:33
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b430479. Configure here.

Comment thread client/templates/requests-proxy-deployment.yaml Outdated
Comment thread client/templates/requests-proxy-deployment.yaml
@saqlainsyed007 saqlainsyed007 merged commit 5b60776 into develop May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants