Reduce dependency on values.yaml file for requests proxy#122
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b430479. Configure here.
b430479 to
60387e1
Compare
saadqbal
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Related
Type of change
Test plan
Screenshots / recordings
Deployment notes
Checklist
Note
Medium Risk
Changes
requests-proxydeployment defaults by hardcoding CPU/memory and forcingimagePullPolicy: Always, which can affect scheduling and rollout/pull behavior across clusters.Overview
requests-proxy’s Helm template now hardcodes its CPU/memory requests+limits and setsimagePullPolicy: Always, rather than reading resource settings (or pull policy) fromvalues.yaml.The image digest lookup is also made more defensive by using
dig "requestsProxy" "digest"against.Values.images, and theresources.requestsProxyblock is removed fromclient/values.yaml.Reviewed by Cursor Bugbot for commit 60387e1. Bugbot is set up for automated code reviews on this repo. Configure here.