Remove REQUESTS_PROXY_ADMIN_TOKEN#120
Merged
Merged
Conversation
saadqbal
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
REQUESTS_PROXY_ADMIN_TOKEN— a Kubernetes Secret, env var injection, and chart value that were never consumed by any runtime code. The requests-proxy server has no admin HTTP API (only pod-facing/v1/resultand/v1/flopsroutes); token validation is handled via per-job Bearer tokens from MySQL. The jobs-manager similarly never reads this env var.Related
Ref tracebloc/client-runtime#33
Type of change
Test plan
helm unittest client/— 116/116 passing (updated document-count assertions innode_agents_namespace_test.yamlto reflect the removed secret)tracebloc/client-runtimethatrequests_proxy_server.pyandjobs_manager.pyhave no references toREQUESTS_PROXY_ADMIN_TOKENDeployment notes
The
{{ .Release.Name }}-requests-proxy-adminSecret will no longer be created on fresh installs. On existing clusters, the orphaned Secret can be deleted manually:No rollout order dependency — neither container reads this env var.
Checklist