Add request proxy url to jobs manager yaml file#119
Merged
Conversation
saadqbal
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related
Type of change
Test plan
Screenshots / recordings
Deployment notes
Checklist
Note
Low Risk
Low risk Helm template change that only adds a new environment variable to the
jobs-managercontainer; main risk is misconfiguration if the service URL is wrong or unavailable at runtime.Overview
Adds
REQUESTS_PROXY_URL(set tohttp://requests-proxy-service:8888) to thejobs-managerDeployment Helm template so the manager can be configured to reach the requests-proxy service.Reviewed by Cursor Bugbot for commit 273835a. Bugbot is set up for automated code reviews on this repo. Configure here.