Skip to content

Add request proxy url to jobs manager yaml file#119

Merged
saqlainsyed007 merged 1 commit into
developfrom
request-proxy
May 12, 2026
Merged

Add request proxy url to jobs manager yaml file#119
saqlainsyed007 merged 1 commit into
developfrom
request-proxy

Conversation

@saqlainsyed007
Copy link
Copy Markdown

@saqlainsyed007 saqlainsyed007 commented May 12, 2026

Summary

Related

Type of change

  • Feature
  • Bug fix
  • Tech-debt / refactor
  • Docs
  • Security / hardening
  • Breaking change

Test plan

Screenshots / recordings

Deployment notes

Checklist

  • Tests added / updated and passing locally
  • Docs updated if behavior or config changed
  • No secrets / credentials in the diff
  • For security-sensitive paths: appropriate reviewer requested

Note

Low Risk
Low risk Helm template change that only adds a new environment variable to the jobs-manager container; main risk is misconfiguration if the service URL is wrong or unavailable at runtime.

Overview
Adds REQUESTS_PROXY_URL (set to http://requests-proxy-service:8888) to the jobs-manager Deployment Helm template so the manager can be configured to reach the requests-proxy service.

Reviewed by Cursor Bugbot for commit 273835a. Bugbot is set up for automated code reviews on this repo. Configure here.

@saqlainsyed007 saqlainsyed007 requested a review from saadqbal as a code owner May 12, 2026 12:35
@saqlainsyed007 saqlainsyed007 merged commit af26953 into develop May 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants