fix: render sibling tabs at parent level in show view#142
Merged
Conversation
Sibling-section navigation tabs (0, 1, ...) and child embed tabs (e.g. LINKS) were both rendered inside each child detail-view's .tabs container, which made child embeds visually peer with the section selectors instead of nested inside their section. Move the sibling navigation into the parent's tabs region so each child's .tabs only contains its own embed tabs. Render numbered tabs for embeds_many regardless of count so single items still get an index link, and hide each numbered row when its embed is not the active selection (via data-tab-group + JS).
tfwright
force-pushed
the
fix/show-sibling-tabs-position
branch
from
32742ad to
e6d8ee2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan