docs(sdk/foundry): make T3 canonical, consolidate T2 deltas into migration appendix#363
Closed
docs(sdk/foundry): make T3 canonical, consolidate T2 deltas into migration appendix#363
Conversation
Mirrors the pattern from #350 for protocol specs. The two inline '#### T2 -> T3 changes' sections in src/pages/sdk/foundry/index.mdx are removed; the surrounding prose now reads as T3-canonical, and the legacy authorizeKey ABI / selector-check material is moved into a single '## T2 → T3 migration' appendix at the bottom. Also drops 'Post-T3' future-tense framing from the forge-create note and the cast-keychain code comment. Amp-Thread-ID: https://ampcode.com/threads/T-019dd9ac-1e55-70ed-89d6-0764dccdf9e8 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #350. PR #350 made T3 the canonical baseline across the protocol specs and consolidated T2-era deltas into a single
## T2 → T3 migrationappendix per page. The Foundry SDK page was missed — it still has two inline#### T2 -> T3 changesheadings plus several "Post-T3 / pre-T3" future-tense phrasings.This PR applies the same pattern to
src/pages/sdk/foundry/index.mdx.Changes
#### T2 -> T3 changesheadings (under thecastinteraction examples and undercast keychain).forge createnote: "Post-T3, access keys can sign calls but not deployments." → "Access keys can sign calls but not deployments."cast keychainintro now describes the supported authorization options directly instead of framing them as a T3 delta.cast keychaincode block.## T2 → T3 migrationappendix at the bottom with an:::info[Migration appendix]callout (matching the protocol specs in T3 docs cleanup: make T3 canonical, consolidate T2 deltas into migration appendix #350). The appendix contains:authorizeKey(...)ABI migration note.### Check your authorizeKey(...) migration with castsection, with internal anchor links updated to point back to the canonicalcast sendandcast keychainexamples above.Out of scope
Verification
grepconfirms the only remainingPost-T3/pre-T3/T3 activationphrasings live inside the new## T2 → T3 migrationappendix.corepack pnpm run checkandcorepack pnpm run check:typesin CI.