Skip to content

docs(sdk/foundry): make T3 canonical, consolidate T2 deltas into migration appendix#363

Closed
max-digi wants to merge 1 commit intomainfrom
mmp/foundry-t3-canonical
Closed

docs(sdk/foundry): make T3 canonical, consolidate T2 deltas into migration appendix#363
max-digi wants to merge 1 commit intomainfrom
mmp/foundry-t3-canonical

Conversation

@max-digi
Copy link
Copy Markdown
Contributor

Follow-up to #350. PR #350 made T3 the canonical baseline across the protocol specs and consolidated T2-era deltas into a single ## T2 → T3 migration appendix per page. The Foundry SDK page was missed — it still has two inline #### T2 -> T3 changes headings plus several "Post-T3 / pre-T3" future-tense phrasings.

This PR applies the same pattern to src/pages/sdk/foundry/index.mdx.

Changes

  • Removed both #### T2 -> T3 changes headings (under the cast interaction examples and under cast keychain).
  • Rewrote surrounding prose as T3-canonical:
    • forge create note: "Post-T3, access keys can sign calls but not deployments." → "Access keys can sign calls but not deployments."
    • Access-key CREATE restriction note now reads as a current rule, not a future one.
    • cast keychain intro now describes the supported authorization options directly instead of framing them as a T3 delta.
    • Dropped "Post-T3, …" from a comment in the cast keychain code block.
  • Added ## T2 → T3 migration appendix at the bottom with an :::info[Migration appendix] callout (matching the protocol specs in T3 docs cleanup: make T3 canonical, consolidate T2 deltas into migration appendix #350). The appendix contains:
    • The pre-T3 → tuple-form authorizeKey(...) ABI migration note.
    • The full ### Check your authorizeKey(...) migration with cast section, with internal anchor links updated to point back to the canonical cast send and cast keychain examples above.

Out of scope

Verification

  • grep confirms the only remaining Post-T3/pre-T3/T3 activation phrasings live inside the new ## T2 → T3 migration appendix.
  • Will run corepack pnpm run check and corepack pnpm run check:types in CI.

Mirrors the pattern from #350 for protocol specs. The two inline
'#### T2 -> T3 changes' sections in src/pages/sdk/foundry/index.mdx
are removed; the surrounding prose now reads as T3-canonical, and
the legacy authorizeKey ABI / selector-check material is moved into
a single '## T2 → T3 migration' appendix at the bottom.

Also drops 'Post-T3' future-tense framing from the forge-create note
and the cast-keychain code comment.

Amp-Thread-ID: https://ampcode.com/threads/T-019dd9ac-1e55-70ed-89d6-0764dccdf9e8
Co-authored-by: Amp <amp@ampcode.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tempo-docs Ready Ready Preview, Comment Apr 29, 2026 2:52pm

Request Review

@max-digi
Copy link
Copy Markdown
Contributor Author

Folded into #350 — the same diff is now commit 1444626 on mmp/remove-t3-upcoming-banner, so all T2→T3 cleanup (protocol specs + sdk/foundry) ships in one PR. Closing to avoid duplicate review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant