Skip to content

refactor(core)!: move #[Priority] to tempest/support#2116

Merged
brendt merged 2 commits into3.xfrom
refactor/priority
Apr 22, 2026
Merged

refactor(core)!: move #[Priority] to tempest/support#2116
brendt merged 2 commits into3.xfrom
refactor/priority

Conversation

@innocenzi
Copy link
Copy Markdown
Member

@innocenzi innocenzi commented Apr 13, 2026

This pull request moves Tempest\Core\Priority to tempest/support.

The reasoning is that it's a class used by multiple packages, which then depend on tempest/core and are harder to use standalone without Tempest.

This is a breaking change, as this attribute might be used in userland, so I added a rector rule for it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2026

Benchmark Results

Comparison of refactor/priority against 3.x (9d11469f3c62f2922865eb2a80f7109cf15eee9a).

Open to see the benchmark results

No benchmark changes above ±5%.

Generated by phpbench against commit 5c88501

@eshimischi
Copy link
Copy Markdown

This is a useful feature for developing libraries dependent on this framework. We ask you to consider adopting these changes soon.

@brendt
Copy link
Copy Markdown
Member

brendt commented Apr 21, 2026

I'm ok with this, but in order to do it non-breaking, did you consider using class_alias? We don't use it atm, but maybe it's not a bad idea?

@brendt
Copy link
Copy Markdown
Member

brendt commented Apr 22, 2026

Discussed the class_alias stuff on Discord. We'll not do it. Rather teach our community that we allow automated breaking changes in minor releases. I'll blog about it though and make the docs a bit more clear about it as well

@brendt brendt merged commit 657e1da into 3.x Apr 22, 2026
76 of 77 checks passed
@brendt brendt deleted the refactor/priority branch April 22, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants