Skip daily mncount writes until Core is synced#28
Merged
Conversation
Guard the daily masternode-count logger with Core IBD and masternode sync checks so startup catch-up cannot persist partial counts while syscoind is still syncing. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/mncountwrites behindgetblockchaininfo.initialblockdownload === false.mnSync('status')to report both blockchain and masternode sync complete before samplingmasternode_count.Production data correction
Corrected the bad
2026-05-04production row from2289to the live total2239;/mncountnow returns2239for today.Test plan
npm test -- --runInBand services/mnCountLogger.test.jsnpm test -- --runInBandMade with Cursor