Skip to content

fix: stabilize send scan routing#925

Draft
ovitrif wants to merge 2 commits intofeat/connection-issues-viewfrom
fix/connection-issues-view
Draft

fix: stabilize send scan routing#925
ovitrif wants to merge 2 commits intofeat/connection-issues-viewfrom
fix/connection-issues-view

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented Apr 30, 2026

Description

Fixes review blockers for #878:

  • Avoids waiting 15 seconds for usable channels when there are no channels or the node cannot become runnable.
  • Stabilizes scan routing by preserving whether a scan started from the main scanner or inside SendSheet before routing.

Also fixes all lint issues accumulated in latest PRs (should later update config to fail on lint errors).

Preview

Before After

QA Notes

Manual Tests

  • 1. No usable channels/spending balance → scan LN invoice: error shows immediately, not after 15s.
  • 2. regression: Scanner → scan fixed amount LN invoice: Send Confirm or QuickPay opens directly.
  • 3a. regression: Send → scanner/paste fixed amount LN invoice: in-sheet nav to Confirm or QuickPay.
    • 3b. regression: Variable amount LN invoice/LNURL-pay: lands on Amount view.

@ovitrif ovitrif force-pushed the fix/connection-issues-view branch from ac51d38 to 8c3e3d1 Compare May 1, 2026 12:06
@ovitrif ovitrif added this to the 2.3.0 milestone May 4, 2026
@ovitrif ovitrif force-pushed the fix/connection-issues-view branch from 8c3e3d1 to 3851847 Compare May 4, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant