jextract/ffm: Treat underscore labels as empty suffixes in function overloads#735
Merged
ktoso merged 1 commit intoswiftlang:mainfrom May 11, 2026
Merged
Conversation
Collaborator
|
This sounds good to me, long term solution as well, thank you! Maybe worth a new issue about the longer term fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a function overload uses an underscore (
_) as an argument label, the generator uses the underscore literally as a suffix for the Java method name.In Swift,
_is not an identifier; it simply denotes the omission of a label. Therefore, IMO, using it as a literal suffix in Java feels unnatural.This PR updates the naming logic for function overloads to treat the
_label as an empty suffix.Notes
This change can lead to name collisions in specific cases. For example:
With this PR, both methods would map to
takeValueB.However, even if we kept the underscore (the previous behavior), collisions would still be unavoidable if a function like
func takeValue_(b: Int)existed.To approach such corner-case collisions, we should eventually provide a way for users to explicitly specify the export name. (like
@JavaExport("export_name")).