Skip to content

fix: community add-on template imports expect from vitest#1090

Merged
jycouet merged 2 commits into
mainfrom
ecosys-humm
May 14, 2026
Merged

fix: community add-on template imports expect from vitest#1090
jycouet merged 2 commits into
mainfrom
ecosys-humm

Conversation

@jycouet
Copy link
Copy Markdown
Contributor

@jycouet jycouet commented May 14, 2026

Closes https://github.com/sveltejs/svelte-ecosystem-ci/actions/runs/25781686887/job/75725574604 issue

Description

We use @playwright/test: ^1.59.1 and on npm i (in tests), it's taking the new https://github.com/microsoft/playwright/releases/tag/v1.60.0 . And the count of expect in vitest is not matching with this playwright change. Anyway, all our expects could be done via vitest, so let's switch to it

Checklist

  • Update snapshots (if applicable)
  • Add a changeset (if applicable)
  • Allow maintainers to edit this PR
  • I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 14, 2026

🦋 Changeset detected

Latest commit: f0cd195

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 14, 2026

Open in StackBlitz

npx https://pkg.pr.new/svelte-migrate@1090
npx https://pkg.pr.new/sv@1090
npx https://pkg.pr.new/@sveltejs/sv-utils@1090

commit: f0cd195

@svelte-docs-bot
Copy link
Copy Markdown

@jycouet jycouet merged commit e2d90f2 into main May 14, 2026
8 checks passed
@jycouet jycouet deleted the ecosys-humm branch May 14, 2026 07:23
@github-actions github-actions Bot mentioned this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant