Skip to content

chore(internal): helping ecosystem-ci#1087

Merged
jycouet merged 2 commits into
sveltejs:mainfrom
jycouet:ecosys
May 8, 2026
Merged

chore(internal): helping ecosystem-ci#1087
jycouet merged 2 commits into
sveltejs:mainfrom
jycouet:ecosys

Conversation

@jycouet
Copy link
Copy Markdown
Contributor

@jycouet jycouet commented May 8, 2026

Description

Test fixtures in tailwindcss and mdsvex addon tests appended markup without checking for prior insertion. With retry: 3 in CI, a flaky first attempt would compound: each retry duplicated the fixture nodes, turning recoverable flakes into hard strict mode violation failures (e.g. this run).

Both fixtures now use transforms.svelte / transforms.svelteScript from sv-utils and short-circuit via return false when a marker node is already present (same pattern as addToDemoPage in addons/common.ts).

Checklist

  • Update snapshots (if applicable)
  • Add a changeset (if applicable) - n/a, internal test infra only
  • Allow maintainers to edit this PR
  • I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2026

⚠️ No Changeset found

Latest commit: 6ec4576

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 8, 2026

Open in StackBlitz

npx https://pkg.pr.new/svelte-migrate@1087
npx https://pkg.pr.new/sv@1087
npx https://pkg.pr.new/@sveltejs/sv-utils@1087

commit: 6ec4576

@jycouet jycouet changed the title test(sv): make tailwindcss & mdsvex addFixture idempotent Helping ecosystem-ci May 8, 2026
@jycouet jycouet changed the title Helping ecosystem-ci chore(internal): helping ecosystem-ci May 8, 2026
@jycouet jycouet merged commit e84a229 into sveltejs:main May 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant