Skip to content

fix(sv): pnpm 11 install no longer fails for cloudflare adapter#1085

Merged
jycouet merged 1 commit into
sveltejs:mainfrom
jycouet:pnpm-11
May 7, 2026
Merged

fix(sv): pnpm 11 install no longer fails for cloudflare adapter#1085
jycouet merged 1 commit into
sveltejs:mainfrom
jycouet:pnpm-11

Conversation

@jycouet
Copy link
Copy Markdown
Contributor

@jycouet jycouet commented May 7, 2026

Closes discord exchange 😅

Description

  • cli/create.ts: resolve package manager before runAddonsApply so pnpm-only logic in add-ons (drizzle, tailwindcss, sveltekit-adapter) actually runs. Previously workspace.packageManager was still 'npm' (default) when add-ons ran, silently skipping if (packageManager === 'pnpm') branches.
  • addons/sveltekit-adapter.ts: register workerd and sharp as pnpm allow-builds when the cloudflare adapter is selected.
  • core/package-manager.ts: on pnpm ERR_PNPM_IGNORED_BUILDS, don't crash. Surface a short warning pointing at pnpm approve-builds and continue.

Checklist

  • Update snapshots (if applicable)
  • Add a changeset (if applicable)
  • Allow maintainers to edit this PR
  • I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

🦋 Changeset detected

Latest commit: de50934

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 7, 2026

Open in StackBlitz

npx https://pkg.pr.new/svelte-migrate@1085
npx https://pkg.pr.new/sv@1085
npx https://pkg.pr.new/@sveltejs/sv-utils@1085

commit: de50934

@jycouet jycouet merged commit 5698e7f into sveltejs:main May 7, 2026
8 checks passed
@github-actions github-actions Bot mentioned this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant