Show alias name as plain string in overwrite warning#2577
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the contract deploy overwrite warning to format the alias using its Display representation (a plain string) rather than Debug, avoiding user-facing output like AliasName("auth") and aligning with other alias-related commands.
Changes:
- Switch alias formatting in the overwrite warning from
{:?}to{}with surrounding single quotes for consistency.
leighmcculloch
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When deploying a contract with
--aliasover an existing alias, the warning message printed the alias using itsDebugrepresentation, producing output likeAliasName("auth"). This change switches it to theDisplayrepresentation with single quotes —'auth'— matching how aliases are formatted elsewhere (e.g.alias add,alias remove).Why
The
AliasName(...)debug form leaked the wrapper type name into user-facing output. The other alias commands already format aliases as'<name>', so this aligns the deploy warning with the rest of the CLI.Known limitations
N/A