Skip to content

test: add missing closing brace in TypeScript test files#12718

Open
Planeshifter wants to merge 1 commit into
developfrom
philipp/fix-missing-closing-brace-ts-tests
Open

test: add missing closing brace in TypeScript test files#12718
Planeshifter wants to merge 1 commit into
developfrom
philipp/fix-missing-closing-brace-ts-tests

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • fixes a syntax error present in 126 lines across 42 docs/types/test.ts files, where a $ExpectError test assertion opened an options object literal with { but omitted the closing } before the call's ), e.g. factory( { 'state': true ); instead of factory( { 'state': true } );. The missing brace is a syntax error that prevents the affected test files from compiling. The closing } is inserted so the lines parse and still trigger the expected type error.
  • additionally corrects two pre-existing incorrect $ExpectType annotations in random/base/frechet and random/base/triangular. These were masked by the syntax error; once the files compile, the expect-type linter flags them. Both distributions take three parameters, so factory() returns a TernaryFunction (not BinaryFunction), matching the declaration files.

Affected namespaces: random/base, random/array, random/iter, and utils/define-memoized-property.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Affected lines were found by scanning docs/types/test.ts files for inline statements (ending in );) where the count of { exceeds the count of }, isolating exactly the unclosed-object-literal case. All affected files pass make eslint-ts-files after the change.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored primarily by Claude Code: it scanned the codebase for the missing-brace pattern, applied the mechanical fixes, identified the two unmasked $ExpectType annotation bugs, and verified the result with the TypeScript test linter. Changes were reviewed by myself.


@stdlib-js/reviewers

Various `$ExpectError` test assertions opened an options object literal
with `{` but omitted the closing `}` before the call's `)`, e.g.
`factory( { 'state': true );`. This is a syntax error which prevents the
affected test files from compiling. Insert the missing `}` so the lines
parse and still trigger the expected type error.

Affects 126 lines across 42 `docs/types/test.ts` files, primarily under
`random/base`, `random/array`, `random/iter`, and one in
`utils/define-memoized-property`.

Fixing the syntax errors allows the expect-type linter to fully analyze
the `random/base/frechet` and `random/base/triangular` test files, which
surfaced two pre-existing incorrect `$ExpectType` annotations. Both
distributions take three parameters, so `factory()` returns a
`TernaryFunction`; correct the annotations accordingly to match the
declaration files.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter changed the title fix: add missing closing brace in TypeScript test files test: add missing closing brace in TypeScript test files Jun 8, 2026
@Planeshifter Planeshifter marked this pull request as ready for review June 8, 2026 21:53
@Planeshifter Planeshifter requested review from a team and kgryte June 8, 2026 21:53
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 8, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
random/array/minstd-shuffle $\color{green}505/505$
$\color{green}+100.00\%$
$\color{green}50/50$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}505/505$
$\color{green}+100.00\%$
random/array/minstd $\color{green}505/505$
$\color{green}+100.00\%$
$\color{green}50/50$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}505/505$
$\color{green}+100.00\%$
random/array/mt19937 $\color{green}505/505$
$\color{green}+100.00\%$
$\color{green}50/50$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}505/505$
$\color{green}+100.00\%$
random/array/randu $\color{green}408/408$
$\color{green}+100.00\%$
$\color{green}31/31$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}408/408$
$\color{green}+100.00\%$
random/base/arcsine $\color{green}485/485$
$\color{green}+100.00\%$
$\color{green}58/58$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}485/485$
$\color{green}+100.00\%$
random/base/beta $\color{red}874/885$
$\color{green}+98.76\%$
$\color{red}119/120$
$\color{green}+99.17\%$
$\color{green}16/16$
$\color{green}+100.00\%$
$\color{red}874/885$
$\color{green}+98.76\%$
random/base/betaprime $\color{green}458/458$
$\color{green}+100.00\%$
$\color{green}47/47$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}458/458$
$\color{green}+100.00\%$
random/base/binomial $\color{green}793/793$
$\color{green}+100.00\%$
$\color{green}100/100$
$\color{green}+100.00\%$
$\color{green}15/15$
$\color{green}+100.00\%$
$\color{green}793/793$
$\color{green}+100.00\%$
random/base/box-muller $\color{green}563/563$
$\color{green}+100.00\%$
$\color{green}50/50$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}563/563$
$\color{green}+100.00\%$
random/base/cauchy $\color{green}489/489$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}489/489$
$\color{green}+100.00\%$
random/base/cosine $\color{green}490/490$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}490/490$
$\color{green}+100.00\%$
random/base/discrete-uniform $\color{red}790/793$
$\color{green}+99.62\%$
$\color{red}88/89$
$\color{green}+98.88\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{red}790/793$
$\color{green}+99.62\%$
random/base/erlang $\color{green}512/512$
$\color{green}+100.00\%$
$\color{green}56/56$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}512/512$
$\color{green}+100.00\%$
random/base/f $\color{green}490/490$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}490/490$
$\color{green}+100.00\%$
random/base/frechet $\color{green}507/507$
$\color{green}+100.00\%$
$\color{green}61/61$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}507/507$
$\color{green}+100.00\%$
random/base/gamma $\color{green}623/623$
$\color{green}+100.00\%$
$\color{green}93/93$
$\color{green}+100.00\%$
$\color{green}13/13$
$\color{green}+100.00\%$
$\color{green}623/623$
$\color{green}+100.00\%$
random/base/gumbel $\color{green}493/493$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}493/493$
$\color{green}+100.00\%$
random/base/improved-ziggurat $\color{green}647/647$
$\color{green}+100.00\%$
$\color{green}57/57$
$\color{green}+100.00\%$
$\color{green}13/13$
$\color{green}+100.00\%$
$\color{green}647/647$
$\color{green}+100.00\%$
random/base/invgamma $\color{green}462/462$
$\color{green}+100.00\%$
$\color{green}53/53$
$\color{green}+100.00\%$
$\color{green}11/11$
$\color{green}+100.00\%$
$\color{green}462/462$
$\color{green}+100.00\%$
random/base/kumaraswamy $\color{red}477/479$
$\color{green}+99.58\%$
$\color{red}53/54$
$\color{green}+98.15\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{red}477/479$
$\color{green}+99.58\%$
random/base/laplace $\color{green}494/494$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}494/494$
$\color{green}+100.00\%$
random/base/levy $\color{green}492/492$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}492/492$
$\color{green}+100.00\%$
random/base/logistic $\color{green}493/493$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}493/493$
$\color{green}+100.00\%$
random/base/lognormal $\color{green}497/497$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}497/497$
$\color{green}+100.00\%$
random/base/minstd-shuffle $\color{green}752/752$
$\color{green}+100.00\%$
$\color{green}78/78$
$\color{green}+100.00\%$
$\color{green}14/14$
$\color{green}+100.00\%$
$\color{green}752/752$
$\color{green}+100.00\%$
random/base/mt19937 $\color{green}913/913$
$\color{green}+100.00\%$
$\color{green}88/88$
$\color{green}+100.00\%$
$\color{green}15/15$
$\color{green}+100.00\%$
$\color{green}913/913$
$\color{green}+100.00\%$
random/base/negative-binomial $\color{green}534/534$
$\color{green}+100.00\%$
$\color{green}89/89$
$\color{green}+100.00\%$
$\color{green}11/11$
$\color{green}+100.00\%$
$\color{green}534/534$
$\color{green}+100.00\%$
random/base/normal $\color{green}489/489$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}489/489$
$\color{green}+100.00\%$
random/base/pareto-type1 $\color{green}499/499$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}499/499$
$\color{green}+100.00\%$
random/base/randi $\color{green}381/381$
$\color{green}+100.00\%$
$\color{green}34/34$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}381/381$
$\color{green}+100.00\%$
random/base/randn $\color{green}402/402$
$\color{green}+100.00\%$
$\color{green}42/42$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}402/402$
$\color{green}+100.00\%$
random/base/randu $\color{green}381/381$
$\color{green}+100.00\%$
$\color{green}34/34$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}381/381$
$\color{green}+100.00\%$
random/base/triangular $\color{green}517/517$
$\color{green}+100.00\%$
$\color{green}66/66$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}517/517$
$\color{green}+100.00\%$
random/base/uniform $\color{green}485/485$
$\color{green}+100.00\%$
$\color{green}58/58$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}485/485$
$\color{green}+100.00\%$
random/base/weibull $\color{green}500/500$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}500/500$
$\color{green}+100.00\%$
random/iter/box-muller $\color{green}290/290$
$\color{green}+100.00\%$
$\color{green}31/31$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}290/290$
$\color{green}+100.00\%$
random/iter/improved-ziggurat $\color{green}289/289$
$\color{green}+100.00\%$
$\color{green}31/31$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}289/289$
$\color{green}+100.00\%$
random/iter/minstd-shuffle $\color{green}286/286$
$\color{green}+100.00\%$
$\color{green}32/32$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}286/286$
$\color{green}+100.00\%$
random/iter/minstd $\color{green}286/286$
$\color{green}+100.00\%$
$\color{green}32/32$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}286/286$
$\color{green}+100.00\%$
random/iter/mt19937 $\color{green}286/286$
$\color{green}+100.00\%$
$\color{green}32/32$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}286/286$
$\color{green}+100.00\%$
random/iter/randn $\color{green}290/290$
$\color{green}+100.00\%$
$\color{green}31/31$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}290/290$
$\color{green}+100.00\%$
utils/define-memoized-property $\color{green}168/168$
$\color{green}+100.00\%$
$\color{green}19/19$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}168/168$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants