test: add missing closing brace in TypeScript test files#12718
Open
Planeshifter wants to merge 1 commit into
Open
test: add missing closing brace in TypeScript test files#12718Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
Various `$ExpectError` test assertions opened an options object literal
with `{` but omitted the closing `}` before the call's `)`, e.g.
`factory( { 'state': true );`. This is a syntax error which prevents the
affected test files from compiling. Insert the missing `}` so the lines
parse and still trigger the expected type error.
Affects 126 lines across 42 `docs/types/test.ts` files, primarily under
`random/base`, `random/array`, `random/iter`, and one in
`utils/define-memoized-property`.
Fixing the syntax errors allows the expect-type linter to fully analyze
the `random/base/frechet` and `random/base/triangular` test files, which
surfaced two pre-existing incorrect `$ExpectType` annotations. Both
distributions take three parameters, so `factory()` returns a
`TernaryFunction`; correct the annotations accordingly to match the
declaration files.
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
docs/types/test.tsfiles, where a$ExpectErrortest assertion opened an options object literal with{but omitted the closing}before the call's), e.g.factory( { 'state': true );instead offactory( { 'state': true } );. The missing brace is a syntax error that prevents the affected test files from compiling. The closing}is inserted so the lines parse and still trigger the expected type error.$ExpectTypeannotations inrandom/base/frechetandrandom/base/triangular. These were masked by the syntax error; once the files compile, the expect-type linter flags them. Both distributions take three parameters, sofactory()returns aTernaryFunction(notBinaryFunction), matching the declaration files.Affected namespaces:
random/base,random/array,random/iter, andutils/define-memoized-property.Related Issues
No.
Questions
No.
Other
Affected lines were found by scanning
docs/types/test.tsfiles for inline statements (ending in);) where the count of{exceeds the count of}, isolating exactly the unclosed-object-literal case. All affected files passmake eslint-ts-filesafter the change.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored primarily by Claude Code: it scanned the codebase for the missing-brace pattern, applied the mechanical fixes, identified the two unmasked
$ExpectTypeannotation bugs, and verified the result with the TypeScript test linter. Changes were reviewed by myself.@stdlib-js/reviewers