Skip to content

test(@stdlib/stats/incr/mpcorrdist): increase tolerance for zero-expected case #12680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Planeshifter wants to merge 2 commits into
base: develop
Choose a base branch
from
+7 −3
Draft

test(@stdlib/stats/incr/mpcorrdist): increase tolerance for zero-expected case #12680

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1f780c
test(@stdlib/stats/incr/mpcorrdist): increase tolerance for zero-expe…
claude Jun 7, 2026
d150af2
test(@stdlib/stats/incr/mpcorrdist): broaden near-zero tolerance cond…
claude Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/node_modules/@stdlib/stats/incr/mpcorrdist/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,8 @@ tape( 'the accumulator function computes a moving sample Pearson product-moment
actual = 0.0; // NOTE: this addresses occasional negative values due to accumulated floating-point error. Based on observation, typically `|actual| ≅ |expected|`, but `actual < 0` and `expected > 0`, suggesting that a sign got "flipped" along the way due to, e.g., operations which theoretically should compute to the same value, but do not due to floating-point error.
}
delta = abs( actual - expected );
if ( expected === 0.0 || actual === 0.0 ) {
tol = 10.0 * EPS;
if ( abs( expected ) < 1.0 ) {
tol = 1.0e6 * EPS;
} else {
tol = 1.0e6 * EPS * abs( expected );
}
Expand Down Expand Up @@ -434,7 +434,11 @@ tape( 'the accumulator function computes a moving sample Pearson product-moment
t.strictEqual( actual, expected, 'returns expected value. dataset: '+i+'. window: '+j+'.' );
} else {
delta = abs( actual - expected );
tol = 1.0e6 * EPS * abs( expected );
if ( abs( expected ) < 1.0 ) {
tol = 1.0e6 * EPS;
} else {
tol = 1.0e6 * EPS * abs( expected );
}
t.strictEqual( delta <= tol, true, 'dataset: '+i+'. window: '+j+'. expected: '+expected+'. actual: '+actual+'. tol: '+tol+'. delta: '+delta+'.' );
}
}
Expand Down