Skip to content

CHC: fixes Bool Integer Promotion Crash (CodeHawk-C Issue #69) #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sipma merged 1 commit into from
Jun 4, 2026
Merged

CHC: fixes Bool Integer Promotion Crash (CodeHawk-C Issue #69) #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions CodeHawk/CHC/cchlib/cCHTypesUtil.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,17 @@ let is_longlong ik =
match ik with ILongLong | IULongLong -> true | _ -> false


(** {1 Integer promotion: C Standard 6.3.1.8}
(** {1 Integer promotion: C Standard 6.3.1.1, 6.3.1.8}

The following may be used in an expression wherever an int or unsigned
int may be used:
- an object or expression with an integer type whose integer conversion
rank is less than or equal to the rank of int and unsigned int.
- a bit-field of type _Bool, int, signed int, unsigned int.

If an int can represent all values of the original type, the value is
converted to an int; otherwise it is converted to an unsigned int. These
are called the integer promotions. A

First, both types are promoted to either signed or unsigned int.

Expand All @@ -442,21 +452,21 @@ let is_longlong ik =
corresponding to the type of the operand with signed integer type.
*)

let get_integer_promotion (ty1:typ) (ty2:typ) =
let get_integer_promotion (ty1: typ) (ty2: typ) =
let promote ik =
match ik with
| IChar | ISChar | IShort -> IInt
| IUChar | IUShort -> IUInt
| IChar | ISChar | IUChar | IShort | IBool -> IInt
| IUShort -> IUInt
| _ -> ik in
let ik = match (ty1,ty2) with
| (TInt (ik1,_), TInt (ik2,_)) ->
let ik = match (ty1, ty2) with
| (TInt (ik1, _), TInt (ik2, _)) ->
let ik1 = promote ik1 in
let ik2 = promote ik2 in
if ik1 = ik2 then
ik1
else
begin
match (ik1,ik2) with
match (ik1, ik2) with
| (IInt, ILong) | (ILong, IInt) -> ILong
| (IInt, ILongLong) | (ILongLong, IInt) -> ILongLong
| (ILong, ILongLong) | (ILongLong, ILong) -> ILongLong
Expand Down
4 changes: 2 additions & 2 deletions CodeHawk/CHC/cchlib/cCHVersion.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,5 @@ object (self)
end

let version = new version_info_t
~version:"0.3.0_20260304"
~date:"2026-03-04"
~version:"0.3.0_20260603"
~date:"2026-06-03"
Loading