Fix broken file descriptors in frozen windows apps#628
Open
ndahn wants to merge 2 commits intospatialaudio:masterfrom
Open
Fix broken file descriptors in frozen windows apps#628ndahn wants to merge 2 commits intospatialaudio:masterfrom
ndahn wants to merge 2 commits intospatialaudio:masterfrom
Conversation
Prevent stderr duplication issues in frozen context on Windows. Fixes spatialaudio#461.
Fix stderr handling for frozen Windows applications
mgeier
reviewed
Apr 25, 2026
| # Duping std file descriptors in a frozen context on windows will corrupt | ||
| # the fd and cause issues with e.g. subprocess.check_output. This happens | ||
| # for example in a compiled pyinstaller exe. See #461 for details. | ||
| if _sys.platform != 'win32' or not getattr(_sys, 'frozen', False): |
Member
There was a problem hiding this comment.
It's probably a matter of taste, but I think this would be easier to understand:
Suggested change
| if _sys.platform != 'win32' or not getattr(_sys, 'frozen', False): | |
| if not (_sys.platform == 'win32' and getattr(_sys, 'frozen', False)): |
Or maybe you could do something like this:
if _sys.platform == 'win32' and getattr(_sys, 'frozen', False):
# the whole comment from above, explaining what's wrong in this case
pass
else:
# the original redirection codeWhat do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #461.