Skip to content

refactor: exclude bink and mss32 fake files, use include of header#57

Open
gynt wants to merge 1 commit intomainfrom
refactor/miles-bink-relocation
Open

refactor: exclude bink and mss32 fake files, use include of header#57
gynt wants to merge 1 commit intomainfrom
refactor/miles-bink-relocation

Conversation

@gynt
Copy link
Copy Markdown
Contributor

@gynt gynt commented May 6, 2026

Addresses the miles (and bink issues) mentioned in #56

Note namespace mss changed to MSS, SND_SoundSystemObj changed to DAT_SoundSystemState
Namespace _enums changed to enums

@TheRedDaemon
Copy link
Copy Markdown
Contributor

TheRedDaemon commented May 7, 2026

Ok, I am a bit confused. Are the fake definition not in scope due to this changes, or do I need to test this?

Could it be possible to just import our Fake headers from the project here into Ghidra without adding it to the export, use the structs and values from there and remove the Fake structure inside the Crusader folder in Ghidra completely?

@gynt
Copy link
Copy Markdown
Contributor Author

gynt commented May 8, 2026

Hmmm, what I wanted to happen is that those Fake files are deleted, as including Mss32.h would be enough to cover all relevant reimplementations, right?

So everything in the /Mss32/ folder in this PR can be removed, right?

So, for example, this usage is now correct, right?
https://github.com/sourcehold/OpenSHC/pull/57/changes#diff-e8268c733d50a21e95087c973d8cd5fb1770c98832895765310f563ca0594571R10-R14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants