chore(examples): drop misleading "compare novao" line from load-time sweep panel#86
Merged
Merged
Conversation
VAO is a per-frame render optimization; it does not meaningfully affect build/ texture-upload time, which is what the load-time sweep measures. Suggesting a VAO A/B on this panel was misleading. The header still shows which VAO mode the run used (informational), just without the compare prompt. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The load-time autosweep panel ended with "Re-run with &novao=true to compare VAO off." But VAO is a per-frame render optimization — it doesn't meaningfully change build/texture-upload time, which is what this sweep measures (and on a vsync-capped TV it's invisible anyway). So the prompt was misleading. Removed it.
The header still shows
(VAO ON/OFF)so you know which mode the run used — just without implying a load-time A/B is meaningful.Default scene unchanged; certified snapshot unaffected.
🤖 Generated with Claude Code