Skip to content

pkg/services: add Engine.GoTickUntil#2003

Open
jmank88 wants to merge 1 commit into
mainfrom
services-engine-until-wait
Open

pkg/services: add Engine.GoTickUntil#2003
jmank88 wants to merge 1 commit into
mainfrom
services-engine-until-wait

Conversation

@jmank88

@jmank88 jmank88 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown

✅ API Diff Results - github.com/smartcontractkit/chainlink-common

✅ Compatible Changes (1)

pkg/services.(*Engine) (1)
  • GoTickUntil — ➕ Added

📄 View full apidiff report

@jmank88 jmank88 force-pushed the services-engine-until-wait branch from d6ec34b to 4f2c57a Compare April 28, 2026 23:31
@jmank88 jmank88 requested a review from pavel-raykov April 29, 2026 11:55
pavel-raykov
pavel-raykov previously approved these changes Apr 29, 2026
@github-actions github-actions Bot added the Stale label May 30, 2026
@jmank88 jmank88 removed the Stale label Jun 1, 2026
@jmank88 jmank88 force-pushed the services-engine-until-wait branch from 4f2c57a to 608b6ba Compare June 1, 2026 22:25
@jmank88 jmank88 force-pushed the services-engine-until-wait branch from 608b6ba to 579da0e Compare June 1, 2026 22:31
@jmank88 jmank88 changed the title pkg/services: add Engine.GoTickUntil & Engine.WaitFor pkg/services: add Engine.GoTickUntil Jun 1, 2026
@smartcontractkit smartcontractkit deleted a comment from github-actions Bot Jun 1, 2026
@jmank88 jmank88 requested a review from pavel-raykov June 1, 2026 22:32
@jmank88

jmank88 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

I removed WaitFor. Though it captured a pattern, it actually didn't integrate with GoTickUtil well, because of the indirection. It also didn't have support for an overridden context, which would have made things messier. Better to inline select statements as needed.

@jmank88 jmank88 marked this pull request as ready for review June 1, 2026 22:45
@jmank88 jmank88 requested a review from a team as a code owner June 1, 2026 22:45
@jmank88 jmank88 requested a review from nolag June 1, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants