serval-admin: serval-builds: rename column Source to Translation#3853
serval-admin: serval-builds: rename column Source to Translation#3853marksvc wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Serval builds administration UI to better reflect the meaning of the “source” column by renaming its header label to “Translation”, aligning the table header with the underlying row.translationBooks content.
Changes:
- Renamed the “Source” table column header to “Translation” in the Serval builds table.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9d2b5b3 to
e784bad
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3853 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 630 630
Lines 40592 40592
Branches 6588 6588
=======================================
Hits 32898 32898
Misses 6661 6661
Partials 1033 1033 ☔ View full report in Codecov by Sentry. |
|
Why? I think this is more ambiguous than the previous wording. Did we come to this decision in the meeting? |
|
No. And I prefer "Source". I'm seeking to use terminology that I thought EITL or Serval have been using. As part of inserting a new column for the Training project and books (in another PR), I am renaming "Source" to "Translation" so the columns can be distinguished according to whether they match the Training books or the Translation books. I'm looking to see why I thought "Translation" was a term being used. I see BuildConfig.cs Well. I'll cancel this PR? |
e784bad to
a2037d9
Compare
"Training books" and "Translation books" makes sense to me when side-by side. A column titled "Translation", especially without something contrasting it, does not make sense to me. Keep in mind the column is kind of showing two things: The source project for translation, and the books that were translated; that's probably part of what makes it difficult to name. The existing name does seem odd to me though; it's titled "Source", when it is actually listing the source project, and the books that were translated. |
marksvc
left a comment
There was a problem hiding this comment.
Thank you. We are swimming in naming trouble with draft generation. I think of the name "Source" here as referring to the text from which the product was "translated" from. And so that means particular books in a particular project.
While the list of books is in fact "the list of books that were translated" and exist in the product (and so a list of resulting books), it's also worth considering that these are the books that were "translated" from. So they are the source-language books from a "translation" perspective. They are the books that were there and were "translated" from.
With that thinking about what is being referred to, there could also be a 3rd column called "Products" that lists the books again. (Not that I plan to do that.)
I will plan to close this PR and consider and adjust the column names after, and in light of introducing the training books column.
(I'm putting "translate" in quotes because of some recent comments I have heard about just what it is that the model is doing.)
@marksvc made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on Nateowami).
Screenshot showing column "Translation":

This change is