LT-20524: Resolve install directories in silent (/quiet) installs#86
Open
johnml1135 wants to merge 1 commit into
Open
LT-20524: Resolve install directories in silent (/quiet) installs#86johnml1135 wants to merge 1 commit into
johnml1135 wants to merge 1 commit into
Conversation
The directory-resolution custom actions (SetDefDataFolder, VerifyDataPath, and the Use*AppFolder/Use*DataFolder/Use*HarvestDataFolder set) were only scheduled in the InstallUISequence, which Windows Installer skips for silent (/quiet, /qn) and basic-UI (/qb) installs. APPFOLDER, DATAFOLDER, and HARVESTDATAFOLDER were therefore left unset, so the application and its harvested data installed to the wrong locations. Schedule the same actions in the InstallExecuteSequence, guarded by 'UILevel < 4' so they only run when the UI sequence does not. Reduced (/passive) and full UI installs keep resolving these in the InstallUISequence, so user-chosen paths are not overridden. VerifyDataPath populates REGDATAFOLDER (used by the conditions) and always returns Success, so it is safe in a silent install.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds directory-resolution custom actions to the InstallExecuteSequence for silent/basic MSI installs, ensuring installation paths (APPFOLDER/DATAFOLDER/HARVESTDATAFOLDER) are set correctly when the UI sequence does not run.
Changes:
- Schedules directory resolution custom actions under
UILevel < 4inInstallExecuteSequence. - Introduces guarded sequencing for default/override/registry-derived folder selection during silent/basic installs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LT-20524 — applications built on this installer (e.g. FieldWorks) fail to install in
/quietmode (PDQ Deploy / PDQ Connect / Intune).The directory-resolution custom actions (
SetDefDataFolder,VerifyDataPath, and theUse*AppFolder/Use*DataFolder/Use*HarvestDataFolderset) were scheduled only in theInstallUISequence. Windows Installer skips that sequence for silent (/quiet,/qn) and basic-UI (/qb) installs, soAPPFOLDER,DATAFOLDER, andHARVESTDATAFOLDERwere never assigned. The application and its harvested data then installed to the wrong locations (for FieldWorks this also brokeICU_DATAresolution and crashed the app on first use)./passiveworked only because it runs the reduced-UI sequence.Fix
Schedule the same directory-resolution actions in the
InstallExecuteSequence, guarded byUILevel < 4so they run only when the UI sequence is skipped. Reduced (/passive) and full UI installs continue to resolve these in theInstallUISequence, so a user-chosen path is never overridden.VerifyDataPathpopulatesREGDATAFOLDER(used by the conditions) and always returnsSuccess, so it is safe in a silent install.This mirrors the corresponding change in the WiX6 installer in
sillsdev/FieldWorks(PR sillsdev/FieldWorks#937).Validation
/quiet,/qb,/passive, GUI) confirming the app folder, harvested-data folder, and shortcut creation.This change is